Software Engineering at Google Chapter #19 - Critique: Google's Code Review Tool (2 of 3)

  • Critique has a notifications / events system
  • Events are emitted to other systems which then take action based upon the events received (run a job / script, send a message to a human, etc)
  • Time spent in reviews is time spent not coding so you should make code review as smooth and easy as possible
  • Having only 2 people involved in the code review process keeps velocity high (“too many cooks in the kitchen”)



Thank you for your time and attention.
Apply what you've learned here.
Enjoy it all.